fix: query bookmarks feedback changes #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
saravmajestic
commented
Jul 11, 2024
src/commands/index.ts
Outdated
| } | ||
| commands.registerCommand( | ||
| "dbtPowerUser.createSqlFile", | ||
| async ({ code, name }: { code?: string; name?: string }) => { |
There was a problem hiding this comment.
To open the code from bookmarks tab, added 2 arguments, code and fileName
saravmajestic
commented
Jul 11, 2024
src/commands/index.ts
Outdated
| window.createTextEditorDecorationType({ | ||
| rangeBehavior: DecorationRangeBehavior.OpenOpen, | ||
| }); | ||
| const fileNamePrefix = name || "poweruser"; |
There was a problem hiding this comment.
no other change except this fileNamePrefix
saravmajestic
commented
Jul 11, 2024
| editBuilder.replace(entireDocumentRange, "\n"); | ||
| workspace.openTextDocument(uri).then((doc) => { | ||
| // set this to sql language so we can bind codelens and other features | ||
| languages.setTextDocumentLanguage(doc, "jinja-sql"); |
There was a problem hiding this comment.
use jinja-sql language
1 task
saravmajestic
commented
Jul 11, 2024
| : typeof self < "u" | ||
| ? self | ||
| : {}; | ||
| ? window |
There was a problem hiding this comment.
most of the changes in this file are formatting changes and this is generated from altimate-components
saravmajestic
changed the title
saravmajestic
commented
Jul 12, 2024
| if (document.uri.scheme !== "untitled" && document.languageId !== "sql") { | ||
| if ( | ||
| document.uri.scheme !== "untitled" && | ||
| document.languageId !== "jinja-sql" |
There was a problem hiding this comment.
converted the new query sql file from sql language to jinja-sql so we can use jinja autocompletes
saravmajestic
commented
Jul 12, 2024
| } | ||
| commands.registerCommand( | ||
| "dbtPowerUser.createSqlFile", | ||
| async ({ code, fileName }: { code?: string; fileName?: string }) => { |
There was a problem hiding this comment.
added these 2 arguments to display selected code from bookmark or history details and with filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
changes
jinja-sqllanguage instead ofsqlto have jinja/dbt auto completions as wellScreenshot/Demo
How to test
Checklist
README.mdupdated and added information about my change